Expand distinct tests for groupby and other operators#476
Closed
Expand distinct tests for groupby and other operators#476
Conversation
- Add comprehensive tests for distinct with groupBy, filter, orderBy, and join operations - Add IVM operator tests for distinct combined with filter, map, groupBy, and complex pipelines - Test distinct behavior with aggregated results and chained operations - Verify distinct works correctly when applied before and after other operators - Fix linting issues with unused variables
- Fix orderBy context references after select operations - Move orderBy before select to avoid context issues - Ensure all distinct tests pass without TypeScript errors
|
Cursor Agent can help with this pull request. Just |
|
More templates
@tanstack/db
@tanstack/db-ivm
@tanstack/electric-db-collection
@tanstack/query-db-collection
@tanstack/react-db
@tanstack/solid-db
@tanstack/svelte-db
@tanstack/trailbase-db-collection
@tanstack/vue-db
commit: |
Contributor
|
Size Change: 0 B Total Size: 64.6 kB ℹ️ View Unchanged
|
Contributor
|
Size Change: 0 B Total Size: 1.16 kB ℹ️ View Unchanged
|
Collaborator
Author
|
replaced by #510 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expand
distinctoperator tests to cover interactions withgroupBy,filter,orderBy,map, andjointo verify correct behavior.A user reported that
distinctwas not working withgroupBy. This PR adds comprehensive tests fordistinctin combination withgroupByand other operators (filter,orderBy,map,join) in bothdbanddb-ivmpackages. All new tests pass, indicating thatdistinctcurrently functions correctly with these operators.